@KevinRansom I adjusted the build so that only

build coreclr 

gets the CoreCLR tools. This vastly reduces the build time and the number of packages fetched when doing

build net40

This keeps it simple for everyone, and doesn't force people to get the CoreCLR tools when they aren't needed.

Sure but build all doesn't work with out the tools directory.

There was an extensive discussion about this at the last F# Software Foundation board meeting, where people gave me strong feedback that the core repositories were too hard to build and that this was putting people off contributing.

Among other things, they said that the builds brought down too many technologies when you were just doing the .NET Framework build of the tools. Likewise, if you're not building Visual Studio then it shouldn't bring down the Visual Studio packages.

So I'd really recommend making build net40 not bring down the CoreCLR bits. Having to use build net40 protofx is just strange.

I’m fine with that … but build all needs to work right ?

From: Don Syme [mailto:[email protected]]
Sent: Thursday, October 27, 2016 2:30 PM
To: Microsoft/visualfsharp [email protected]
Cc: Kevin Ransom [email protected]; Mention [email protected]
Subject: Re: [Microsoft/visualfsharp] Ensure that build all gets coreclr tools and builds proto using coreclr (#1674)

There was an extensive discussion about this at the last F# Software Foundation board meeting, where people gave me strong feedback that the core repositories were too hard to build and that this was putting people off contributing.

Among other things, they said that the builds brought down too many technologies when you were just doing the .NET Framework build of the tools. Likewise, if you're not building Visual Studio then it shouldn't bring down the Visual Studio packages.

So I'd really recommend making build net40 not bring down the CoreCLR bits. Having to use build net40 protofx is just strange.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvisualfsharp%2Fpull%2F1674%23issuecomment-256775544&data=02%7C01%7CKevin.Ransom%40microsoft.com%7C50530af5e614494b4a4108d3feb06c8c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636132006105359704&sdata=fIrBOc8uG62v5AtidKBMdZvqeTUX7IkK3qcwPbAqdVk%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAE76FkMxwnmyWTjh7hCDBcdmmvdvko9jks5q4RfdgaJpZM4Ki1rK&data=02%7C01%7CKevin.Ransom%40microsoft.com%7C50530af5e614494b4a4108d3feb06c8c%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636132006105359704&sdata=%2FjUgpirUKdmVkctxeTKYyko2c43QltTdCayTkd6G26w%3D&reserved=0.

Sure but build all doesn't work with out the tools directory.

Ah ok. You're right. Then anything that sets BUILD_CORECLR=1 should also set BUILD_PROTO_WITH_CORECLR_LKG=1 for now.

Yes … I think that’s the change I made unless I missed one.

From: Don Syme [mailto:[email protected]]
Sent: Thursday, October 27, 2016 2:32 PM
To: Microsoft/visualfsharp [email protected]
Cc: Kevin Ransom [email protected]; Mention [email protected]
Subject: Re: [Microsoft/visualfsharp] Ensure that build all gets coreclr tools and builds proto using coreclr (#1674)

Sure but build all doesn't work with out the tools directory.

Ah ok. You're right. Then anything that sets BUILD_CORECLR=1 should also set BUILD_PROTO_WITH_CORECLR_LKG=1 for now.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvisualfsharp%2Fpull%2F1674%23issuecomment-256775946&data=02%7C01%7CKevin.Ransom%40microsoft.com%7C3e2a99a81a474feb196e08d3feb0aebc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636132007199199703&sdata=LR5ossbeYM10F8glJcuQJoExljokFfDd5dxyiCpVYnU%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAE76FjtbS2mL4O-dQiCxGSx06OqHCdViks5q4RhNgaJpZM4Ki1rK&data=02%7C01%7CKevin.Ransom%40microsoft.com%7C3e2a99a81a474feb196e08d3feb0aebc%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636132007199199703&sdata=criyjW6dH9ovXsEcoge1AMGNZTvNpjRPWmiZrf3lPis%3D&reserved=0.

• approved