Skip to content

Conversation

@OmarTawfik
Copy link
Contributor

Fixes #1596
@Microsoft/fsharp-compiler

@Pilchie
Copy link
Member

Pilchie commented Oct 18, 2016

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the user see the project diagnostics at all? Or only on build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsyme If you build the project, they will show up in output pane (from MSBuild) and error pane (from Roslyn service in this change). But they won't be highlighted on source code as the bug reported.

@OmarTawfik OmarTawfik merged commit 1d303ea into dotnet:master Oct 19, 2016
@OmarTawfik OmarTawfik deleted the fix-1596-project-diagnostics branch October 19, 2016 18:09
Copy link
Contributor

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants