Add fsx files to workspaces #1612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pilchie
approved these changes
Oct 14, 2016
| member this.SetupProjectFile(siteProvider: IProvideProjectSite, workspace: VisualStudioWorkspaceImpl) = | ||
| let site = siteProvider.GetProjectSite() | ||
| let projectGuid = Guid(site.ProjectGuid) | ||
| let projectFileName = site.ProjectFileName() |
Member
There was a problem hiding this comment.
Should this be handling exceptions from reading files on disk?
Should it get the text from the in-editor file, since it's in the RDT now.
KevinRansom
suggested changes
Oct 14, 2016
| | _ -> () | ||
|
|
||
| member this.SetupStandAloneFile(fileName: string, workspace: VisualStudioWorkspaceImpl, hier: IVsHierarchy) = | ||
| let sourceText = File.ReadAllText(fileName) |
Contributor
There was a problem hiding this comment.
| let projectContextFactory = this.Package.ComponentModel.GetService<IWorkspaceProjectContextFactory>(); | ||
| let errorReporter = ProjectExternalErrorReporter(projectId, "FS", this.SystemServiceProvider) | ||
| let outputFlag = site.CompilerFlags() |> Seq.pick(fun flag -> | ||
| if flag.StartsWith("-o:") then Some(flag.Substring(3)) |
Contributor
There was a problem hiding this comment.
/out:fn.exe is also valid.
Contributor
Author
There was a problem hiding this comment.
I'll stop using this all together, as it is only used to update CPS references (not implemented yet).
Contributor
Author
|
@KevinRansom stopped depending on files API. Can you please re-review? |
dsyme
pushed a commit
to dsyme/fsharp
that referenced
this pull request
Oct 17, 2016
* Add fsx files to workspaces * Stop passing project output paths to CPS * Read script file contents from memory (on workspace initialization)
dsyme
added a commit
to dsyme/fsharp
that referenced
this pull request
Oct 17, 2016
commit 2a991b6 Author: Don Syme <[email protected]> Date: Mon Oct 17 20:40:15 2016 +0100 Fix microbuild (dotnet#1629) commit 169d366 Author: Kevin Ransom (msft) <[email protected]> Date: Sun Oct 16 15:04:50 2016 -0700 Add missed file. (dotnet#1625) * Ensure that portable libraries have correct hintpath for preview 5 * Replaced missed file commit d64ff35 Author: Don Syme <[email protected]> Date: Sun Oct 16 22:37:08 2016 +0100 cleanup build and test scripts (dotnet#1615) * cleanup build and test scripts commit 39480c4 Author: Kevin Ransom (msft) <[email protected]> Date: Sun Oct 16 10:19:03 2016 -0700 Ensure that portable libraries have correct hintpath for preview 5 (dotnet#1624) commit 2fe5a3b Author: Kevin Ransom (msft) <[email protected]> Date: Sat Oct 15 14:03:48 2016 -0700 Add support for generating sourcelink record in portable pdbs. Fixes dotnet#1585 commit e0318a8 Author: Kevin Ransom (msft) <[email protected]> Date: Sat Oct 15 13:32:44 2016 -0700 FSharp ms build task to support new xommand line options (dotnet#1616) commit 749ba2d Author: Omar Tawfik <[email protected]> Date: Sat Oct 15 13:27:14 2016 -0700 Don't match braces at the end of the caret (dotnet#1619) commit 00bab99 Author: Kevin Ransom (msft) <[email protected]> Date: Sat Oct 15 13:25:15 2016 -0700 (Nugetize F# templates. Ensure value tuple installed on create template. (dotnet#1620) commit 2a9b5ef Author: Omar Tawfik <[email protected]> Date: Fri Oct 14 22:45:35 2016 -0700 Add fsx files to workspaces (dotnet#1612) * Add fsx files to workspaces * Stop passing project output paths to CPS * Read script file contents from memory (on workspace initialization) commit 8b434e0 Author: Kevin Ransom (msft) <[email protected]> Date: Fri Oct 14 10:32:59 2016 -0700 Don't try to deploy vsix during OSS build. Specify prereq in vsixmanifest (dotnet#1613) commit 79430d2 Author: Don Syme <[email protected]> Date: Fri Oct 14 15:58:08 2016 +0100 simplify use of if-defs (dotnet#1614) commit b708921 Author: Don Syme <[email protected]> Date: Fri Oct 14 10:25:28 2016 +0100 Always use FSharp.Core not fsharp.core (dotnet#1610)
KevinRansom
added a commit
that referenced
this pull request
Oct 22, 2016
* Always use FSharp.Core not fsharp.core (#1610) * simplify use of if-defs (#1614) * Don't try to deploy vsix during OSS build. Specify prereq in vsixmanifest (#1613) * Add fsx files to workspaces (#1612) * Add fsx files to workspaces * Stop passing project output paths to CPS * Read script file contents from memory (on workspace initialization) * (Nugetize F# templates. Ensure value tuple installed on create template. (#1620) * Don't match braces at the end of the caret (#1619) * FSharp ms build task to support new xommand line options (#1616) * Add support for generating sourcelink record in portable pdbs. Fixes #1585 * Ensure that portable libraries have correct hintpath for preview 5 * Ensure that portable libraries have correct hintpath for preview 5 (#1624) * cleanup build and test scripts (#1615) * cleanup build and test scripts * Replaced missed file * Fix merge issue * fix merge error * Fix ngen build error
KevinRansom
added a commit
that referenced
this pull request
Oct 25, 2016
* Always use FSharp.Core not fsharp.core (#1610) * simplify use of if-defs (#1614) * Don't try to deploy vsix during OSS build. Specify prereq in vsixmanifest (#1613) * Add fsx files to workspaces (#1612) * Add fsx files to workspaces * Stop passing project output paths to CPS * Read script file contents from memory (on workspace initialization) * (Nugetize F# templates. Ensure value tuple installed on create template. (#1620) * Don't match braces at the end of the caret (#1619) * FSharp ms build task to support new xommand line options (#1616) * Add support for generating sourcelink record in portable pdbs. Fixes #1585 * Ensure that portable libraries have correct hintpath for preview 5 * Ensure that portable libraries have correct hintpath for preview 5 (#1624) * cleanup build and test scripts (#1615) * cleanup build and test scripts * Replaced missed file * Fix merge issue * fix merge error * update build tools * reset build_coreclr * Fix coreclr proto build * Typo
KevinRansom
added a commit
that referenced
this pull request
Oct 26, 2016
* Always use FSharp.Core not fsharp.core (#1610) * simplify use of if-defs (#1614) * Don't try to deploy vsix during OSS build. Specify prereq in vsixmanifest (#1613) * Add fsx files to workspaces (#1612) * Add fsx files to workspaces * Stop passing project output paths to CPS * Read script file contents from memory (on workspace initialization) * (Nugetize F# templates. Ensure value tuple installed on create template. (#1620) * Don't match braces at the end of the caret (#1619) * FSharp ms build task to support new xommand line options (#1616) * Add support for generating sourcelink record in portable pdbs. Fixes #1585 * Ensure that portable libraries have correct hintpath for preview 5 * Ensure that portable libraries have correct hintpath for preview 5 (#1624) * cleanup build and test scripts (#1615) * cleanup build and test scripts * Replaced missed file * Fix merge issue * fix merge error * Update to nunit 3.5
KevinRansom
added a commit
that referenced
this pull request
Oct 27, 2016
* Always use FSharp.Core not fsharp.core (#1610) * simplify use of if-defs (#1614) * Don't try to deploy vsix during OSS build. Specify prereq in vsixmanifest (#1613) * Add fsx files to workspaces (#1612) * Add fsx files to workspaces * Stop passing project output paths to CPS * Read script file contents from memory (on workspace initialization) * (Nugetize F# templates. Ensure value tuple installed on create template. (#1620) * Don't match braces at the end of the caret (#1619) * FSharp ms build task to support new xommand line options (#1616) * Add support for generating sourcelink record in portable pdbs. Fixes #1585 * Ensure that portable libraries have correct hintpath for preview 5 * Ensure that portable libraries have correct hintpath for preview 5 (#1624) * cleanup build and test scripts (#1615) * cleanup build and test scripts * Replaced missed file * Fix merge issue * fix merge error * Update to nunit 3.5 * revert unit runner to 3.0.0 * move back to local packages. * revert to nuget
KevinRansom
added a commit
that referenced
this pull request
Oct 27, 2016
* Always use FSharp.Core not fsharp.core (#1610) * simplify use of if-defs (#1614) * Don't try to deploy vsix during OSS build. Specify prereq in vsixmanifest (#1613) * Add fsx files to workspaces (#1612) * Add fsx files to workspaces * Stop passing project output paths to CPS * Read script file contents from memory (on workspace initialization) * (Nugetize F# templates. Ensure value tuple installed on create template. (#1620) * Don't match braces at the end of the caret (#1619) * FSharp ms build task to support new xommand line options (#1616) * Add support for generating sourcelink record in portable pdbs. Fixes #1585 * Ensure that portable libraries have correct hintpath for preview 5 * Ensure that portable libraries have correct hintpath for preview 5 (#1624) * cleanup build and test scripts (#1615) * cleanup build and test scripts * Replaced missed file * Fix merge issue * fix merge error * Update to nunit 3.5 * revert unit runner to 3.0.0 * Reduce number of times check path for illegal chars occurs in cropextension
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
commit 2a991b6 Author: Don Syme <[email protected]> Date: Mon Oct 17 20:40:15 2016 +0100 Fix microbuild (dotnet#1629) commit 169d366 Author: Kevin Ransom (msft) <[email protected]> Date: Sun Oct 16 15:04:50 2016 -0700 Add missed file. (dotnet#1625) * Ensure that portable libraries have correct hintpath for preview 5 * Replaced missed file commit d64ff35 Author: Don Syme <[email protected]> Date: Sun Oct 16 22:37:08 2016 +0100 cleanup build and test scripts (dotnet#1615) * cleanup build and test scripts commit 39480c4 Author: Kevin Ransom (msft) <[email protected]> Date: Sun Oct 16 10:19:03 2016 -0700 Ensure that portable libraries have correct hintpath for preview 5 (dotnet#1624) commit 2fe5a3b Author: Kevin Ransom (msft) <[email protected]> Date: Sat Oct 15 14:03:48 2016 -0700 Add support for generating sourcelink record in portable pdbs. Fixes dotnet#1585 commit e0318a8 Author: Kevin Ransom (msft) <[email protected]> Date: Sat Oct 15 13:32:44 2016 -0700 FSharp ms build task to support new xommand line options (dotnet#1616) commit 749ba2d Author: Omar Tawfik <[email protected]> Date: Sat Oct 15 13:27:14 2016 -0700 Don't match braces at the end of the caret (dotnet#1619) commit 00bab99 Author: Kevin Ransom (msft) <[email protected]> Date: Sat Oct 15 13:25:15 2016 -0700 (Nugetize F# templates. Ensure value tuple installed on create template. (dotnet#1620) commit 2a9b5ef Author: Omar Tawfik <[email protected]> Date: Fri Oct 14 22:45:35 2016 -0700 Add fsx files to workspaces (dotnet#1612) * Add fsx files to workspaces * Stop passing project output paths to CPS * Read script file contents from memory (on workspace initialization) commit 8b434e0 Author: Kevin Ransom (msft) <[email protected]> Date: Fri Oct 14 10:32:59 2016 -0700 Don't try to deploy vsix during OSS build. Specify prereq in vsixmanifest (dotnet#1613) commit 79430d2 Author: Don Syme <[email protected]> Date: Fri Oct 14 15:58:08 2016 +0100 simplify use of if-defs (dotnet#1614) commit b708921 Author: Don Syme <[email protected]> Date: Fri Oct 14 10:25:28 2016 +0100 Always use FSharp.Core not fsharp.core (dotnet#1610)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Microsoft/fsharp-compiler @cartermp
Fixes #1590