Fix ilread cache #1605
Merged
Fix ilread cache #1605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on FSharp.Compiler.Service for .NET Core I noticed that there is a flaw in the cache used for IL readers in ilread.fs: the cache key should include the primary assembly name (i.e. the cache could incorrectly confuse mscorlib-based interpretations of assemblies with System.Runtime-based interpretations).
For example this could repro in situations where Visual Studio was being used to edit a mix of projects using both System.Runtime Profiles and mscorlib profiles.
This is significant enough that we need to integrate the fix back into this repo.