factor out reference resolution #1593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
force-pushed
the
msbuild-45
branch
2 times, most recently
from
e4a715a to
7059ab5
Compare
Contributor
Author
|
AppVeyor timed out at 1 hour - just as it was uploading results - rerunning that now - otherwise I think this will be ready to go (assuming Jenkins shows green) |
KevinRansom
approved these changes
Oct 11, 2016
| PF + @"\Reference Assemblies\Microsoft\Framework\.NETFramework" | ||
|
|
||
|
|
||
| /// When targeting .NET 2.0-3.5 on Windows, we expand the {WindowsFramework} and {ReferenceAssemblies} paths manually |
Contributor
There was a problem hiding this comment.
We seem to be a bit iffy on support for prior to 4.0. I'm not certain that we have a consistent position. I do know we do no testing. Perhaps we should consider demanding 4.0 or up.
Contributor
Author
There was a problem hiding this comment.
FSharp.Core 4.0..0.0+ requires a matching mscorlib 4.0 reference. The comment above is just out of date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This factors out MSBuild reference resolution into one file, MSBuildReferenceResolver.fs, right at the end of the compilation list. If you don't have this file, the compiler code can be built without reference to MSBuild
The "cut" point is basically the Resolve function of ReferenceResolution.fs.
The "ReferenceResolver.fs" API is far from perfect but can be iterated on from here. At least it's easy to see the points where we are choosing to have a dependency on MSBuild
This also simplifies the API implied by the cut function, removing rid of some old unused internal compiler options and not propagating so much MSBuild information around (information only used to format a tooltip).