Embedded source #1591
Merged
Embedded source #1591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dotnet-bot bot test this please |
dsyme
reviewed
Oct 11, 2016
| static let chunkSize = 32 * 1024 | ||
| let builder = new BlobBuilder(chunkSize) | ||
|
|
||
| override this.CanWrite with get() = true |
Contributor
There was a problem hiding this comment.
"with get()" is not idiomatic - you can just remove it
dsyme
reviewed
Oct 11, 2016
| let documentIndex = | ||
| let includeSource file = | ||
| let isInList = | ||
| if embedSourceList |> List.length = 0 then false |
Contributor
There was a problem hiding this comment.
You can just use .Length instead of |> List.length
dsyme
reviewed
Oct 11, 2016
| if embedSourceList |> List.length = 0 then false | ||
| else | ||
| match embedSourceList |> List.tryFind(fun f -> String.Compare(file, f, StringComparison.OrdinalIgnoreCase ) = 0) with | ||
| | Some _ -> true |
Contributor
There was a problem hiding this comment.
This match is the same as |> Option.isSome?
dsyme
reviewed
Oct 11, 2016
| metadata.GetOrAddGuid(hashAlg), | ||
| metadata.GetOrAddBlob(checkSum.ToImmutableArray()), | ||
| metadata.GetOrAddGuid(corSymLanguageTypeFSharp) | ||
| let h = |
Contributor
|
Nice work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for embedded source code files in pdbs.
Update command line to support /embed and /embed:
Add some more command line testing.
Do not support /embed in fsi.