Skip to content

Fixing code fixes, part 5#15663

Merged
psfinaki merged 11 commits intodotnet:mainfrom
psfinaki:codefixes-18
Jul 31, 2023
Merged

Fixing code fixes, part 5#15663
psfinaki merged 11 commits intodotnet:mainfrom
psfinaki:codefixes-18

Conversation

@psfinaki
Copy link
Copy Markdown
Contributor

@psfinaki psfinaki commented Jul 21, 2023

This PR focuses on our bulk code fixes, six out of nine. They are rewritten, extended, fixed, tested.

In particular, the PR:


This PR does not address unused parameters, signature files, code fixes related to the IDE diags. Next time.

@psfinaki psfinaki requested a review from a team as a code owner July 21, 2023 20:40
Comment thread vsintegration/src/FSharp.Editor/CodeFixes/FixIndexerAccess.fs
Comment thread vsintegration/src/FSharp.Editor/CodeFixes/RemoveUnusedBinding.fs
Comment thread vsintegration/src/FSharp.Editor/CodeFixes/FixIndexerAccessLegacy.fs
@psfinaki
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

Comment thread vsintegration/src/FSharp.Editor/CodeFixes/RenameUnusedValue.fs Outdated
Comment thread vsintegration/src/FSharp.Editor/CodeFixes/RenameUnusedValue.fs Outdated
Comment thread vsintegration/src/FSharp.Editor/CodeFixes/RenameUnusedValue.fs Outdated
Comment thread vsintegration/src/FSharp.Editor/CodeFixes/RenameUnusedValue.fs
Comment thread vsintegration/src/FSharp.Editor/CodeFixes/CodeFixHelpers.fs Outdated
Comment thread vsintegration/src/FSharp.Editor/CodeFixes/CodeFixHelpers.fs Outdated
Comment thread vsintegration/src/FSharp.Editor/CodeFixes/CodeFixHelpers.fs Outdated
Comment thread vsintegration/src/FSharp.Editor/CodeFixes/CodeFixHelpers.fs Outdated
Comment thread vsintegration/src/FSharp.Editor/CodeFixes/CodeFixHelpers.fs Outdated
Comment thread vsintegration/src/FSharp.Editor/CodeFixes/CodeFixHelpers.fs Outdated
@psfinaki psfinaki enabled auto-merge (squash) July 28, 2023 17:43
@psfinaki psfinaki merged commit 6838eab into dotnet:main Jul 31, 2023
@psfinaki psfinaki deleted the codefixes-18 branch July 31, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

4 participants