Hi @mrinaldi, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

This looks like a solid fix, I'm happy.

@KevinRansom That was fast :) TBH several additional reviewers would be welcome, especially since it's Async code.

We have a huge problem with the new msbuild and the compiler dependence on it. As far as I can tell, and Omar has better details but it seems as if the compiler and fsi will need to be run from a VS cmd window for the msbuild magic to work.

I may have to knuckle down and figure out the new referencing magic I’ve been whining about for 18 months.

Kevin

From: Don Syme [mailto:[email protected]]
Sent: Friday, September 23, 2016 10:36 AM
To: Microsoft/visualfsharp [email protected]
Cc: Kevin Ransom [email protected]; Mention [email protected]
Subject: Re: [Microsoft/visualfsharp] Dispose when async workflow is cancelled (#1555)

@KevinRansomhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FKevinRansom&data=01%7C01%7CKevin.Ransom%40microsoft.com%7C56220dc62e814748a45808d3e3d820e3%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=6wl5VWamfDrFCkoE%2B11VsyC70hmC4qFK2VqKQNpbuE4%3D&reserved=0 That was fast :) TBH several additional reviewers would be welcome, especially since it's Async code.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fvisualfsharp%2Fpull%2F1555%23issuecomment-249255207&data=01%7C01%7CKevin.Ransom%40microsoft.com%7C56220dc62e814748a45808d3e3d820e3%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=UKPVpy6yyuRk7upKMx2Kg4fZO6hv2JZOysNJ7hTZ3Ns%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAE76Fv-XaujttjRAjIZil2HjCJcuU9IBks5qtA4RgaJpZM4KCS0R&data=01%7C01%7CKevin.Ransom%40microsoft.com%7C56220dc62e814748a45808d3e3d820e3%7C72f988bf86f141af91ab2d7cd011db47%7C1&sdata=hfkcqgZ7gQ6h7AXVcThyXECDh89bc3lWwf0Z%2BogiUSk%3D&reserved=0.

LGTM 👍