Don't suggest types that are not accessible #1552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ok I think the suggestions are fixed. Regarding reporting of multiple errors:
@dsyme this looks supicious. we want do error recovery here, but the error was already reported |
forki
changed the title
Contributor
Author
|
This fixes the part of #1548 where inaccessible types where reported |
forki
force-pushed
the
i1548
branch
2 times, most recently
from
1b48783 to
b2eb241
Compare
forki
changed the title
Contributor
Author
|
@dotnet-bot test this please |
Contributor
|
@dotnet-bot test this please |
forki
changed the title
Contributor
Author
|
rebased. |
Contributor
|
Contributor
Author
|
fixed! |
Contributor
|
This file has been added: I don't think it should be there? |
Contributor
Author
|
IIRC (it's long time) but that file is needed for the repro. Please take a
look at the corresponding test.
Am 24.11.2016 11:00 nachm. schrieb "Don Syme" <[email protected]>:
… This file has been added:
tests/fsharpqa/Source/Warnings/Repro1548.dll
I don't think it should be there?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1552 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNOSaZ7CSDSv8yih0NDV-5ccTEFWaks5rBgjwgaJpZM4KAddK>
.
|
Contributor
|
Merged, great to have this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.