Roslyn GoToDefinition Service Integration #1540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Explicitly tagging @CyrusNajmabadi, @jasonmalinowski, @dpoeschl as the team mention of @dotnet/roslyn-ide didn't seem to work |
KevinRansom
reviewed
Sep 16, 2016
|
|
||
| let filePath = Path.GetTempFileName() + ".fs" | ||
| let options: FSharpProjectOptions = { | ||
| ProjectFileName = "C:\\test.fsproj" |
Contributor
There was a problem hiding this comment.
c:\test.fsproj is that what we want to do here?
Contributor
Author
There was a problem hiding this comment.
Just a placeholder to create a dummy object to pass to the service.
Actual compiler service tests are in Tests.LanguageService.GotoDefinition.fs. This file contains the tests that target the Roslyn service export.
Member
|
Looks ok to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Microsoft/visualfsharp @dotnet/roslyn-ide