Skip to content

Conversation

@KevinRansom
Copy link
Contributor

This PR embeds compressed PDBs into the built binary.
It adds embedded as an option to --debug
updates command line tests.

@dsyme
Copy link
Contributor

dsyme commented Sep 12, 2016

"This branch has conflicts that must be resolved"?

//---------------------------------------------------------------------
// Portable PDB Writer
//---------------------------------------------------------------------
type BinaryChunk =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this in ilwrite.fsi. It is not pdb specific.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foo

--resource:<resinfo> Embed the specified managed resource
--linkresource:<resinfo> Link the specified resource to this assembly
where the resinfo format is <file>[,<string
name>[,public|private]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the help text still look OK visually when printed on an 80-column console window? thanks

@dsyme
Copy link
Contributor

dsyme commented Sep 13, 2016

@KevinRansom Please add at least one invocation of the compiler that uses --debug:embedded to the automated tests? Also jot down the manual sanity checks that have been done? thanks

@KevinRansom
Copy link
Contributor Author

1: I will add a smoke test when I have a machine that build again ... I am paying a steep price for having to install the latest internal VS builds right now.
2: Verification Built and debugged F# compiler (Net40 debug build):
. Full pdbs
. Portable pdbs
and Embedded pdb

full pdbs.

@KevinRansom KevinRansom merged commit ea60a9d into master Sep 15, 2016
@KevinRansom KevinRansom deleted the embed branch September 16, 2016 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants