Pretty Print Value of Public Fields in FSI #1484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @liboz, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
liboz
changed the title
liboz
changed the title
Contributor
Author
|
Ready for review |
| | true -> | ||
| // we have a hit on a property reference | ||
| let preText = replaceEscapedBrackets(m.Groups.["pre"].Value) // everything before the first opening bracket | ||
| let postText = m.Groups.["post"].Value // Everything after the closing bracket |
Contributor
There was a problem hiding this comment.
Up at line 832:
we get x.GetType() again ... I suppose we can remove it and use the ty that we fetched in 827
let ty = x.GetType()
if ty.IsGenericType && ty.GetGenericTypeDefinition() = typedefof<Lazy<_>> then
Some (wordL (x.ToString()))
else
// Try the StructuredFormatDisplayAttribute extensibility attribute
match x.GetType().GetCustomAttributes (typeof<StructuredFormatDisplayAttribute>, true) with
Contributor
|
@liboz Kevin |
Contributor
|
This is great Thank you for taking care of this. Kevin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1382. Also has some minor cleanup