dk:

 are those just stylistic changes?

forki:

nope. I'm replacing internal functions with the ones from FSharp.Core
these are sometimes better optimized (at least people try to do this) and sometimes get inlined
so this could be beneficial for compiler perf

On a shallow examination all changes seem to preserve existing logic.

My only nitpick is not (List.isEmpty ...) repetition everywhere. I would consider letting nonNil live on.

My preference is how Steffen has it now, it is clearer and not really many more characters.

The real advantage is that we got rid of a couple of these manual helper
functions that we have everywhere

Am 23.08.2016 19:40 schrieb "Kevin Ransom (msft)" <[email protected]

:

My preference is how Steffen has it now, it is clearer and not really many
more characters.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1476 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNDImgaLkYSvWIqtaroNiUPNdETWXks5qizCUgaJpZM4Jq5CM
.

ok I think it's ready to go in.

Looks good to me.