FSharp.Compiler.dll and the FSharp.LanguageService.Compiler.dll compiled with peverify issues. #1465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| new System.String(NativePtr.ofNativeInt (m.Addr i), 0, n, System.Text.Encoding.UTF8) | ||
| #endif | ||
| System.Runtime.InteropServices.Marshal.PtrToStringAnsi((m.Addr i), n) | ||
| //#if FX_RESHAPED_REFLECTION |
Contributor
|
I can rebase my PR and rerun the build after you merge the existing fix. |
Contributor
|
I don't think this needed a fix - the code used was valid IL and there was no functionality bug here. It's just that the code was not verifiable. Not all valid IL code is verifiable. For example, managed C++ and unsafe C# would have emitted equivalent code AFAIK. But what I'm most concerned about is a perf regression. If Marshal.ReadByte is slower in any way (how do we know? does it do any kind of check?) then we will likely see a perf regression on binary reading. Best not to take the risk at this stage. best |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FSharp.Compiler.dll and the FSharp.LanguageService.Compiler.dll compiled with peverify issues.