Implement mouseover tooltips for keywords #13956
Conversation
* Streamlining dependencies around Microsoft.CodeAnalysis * Update
…ment-tooltips-for-keywords
…ment-tooltips-for-keywords
T-Gro
requested review from
0101,
KevinRansom,
abonie,
dsyme,
psfinaki and
vzarytovskii
|
|
psfinaki
left a comment
psfinaki
left a comment
There was a problem hiding this comment.
So I'd probably remove the icons at all, I don't see any particular value in having them whereas they take space :)
Otherwise - awesome!
We do use icons in other tooltips, always fitting the respective token (property, class, method,... have their own icons). |
- updating .expected SurfaceArea file
Sure. I don't have a strong opinion here :) |
| ParamName: string option | ||
| } | ||
|
|
||
| static member Create: layout: TaggedText[] * xml: FSharpXmlDoc * ?typeMapping: TaggedText[] list * ?paramName: string * ?remarks: TaggedText[] -> ToolTipElementData |
There was a problem hiding this comment.
Could this be internal please? I think it is only used from FSharpCheckerResults.fs? Thanks
| val KeywordsWithDescription: (string * string) list | ||
|
|
||
| /// A lookup from keywords to their descriptions | ||
| val KeywordsDescriptionLookup: System.Collections.Generic.IDictionary<string, string> |
There was a problem hiding this comment.
Could this be a string -> string option method please, GetKeywordDescription? Rather than revealing an IDictionary?
This PR implements mouseover tooltips for keywords in Visual Studio.
This already works in FsAutoComplete (Ionide) and this new VS implementation uses the same data source, provided by Compiler Services.
Here is a visual example.
REMARK:
In order to test, I had to rebase this branch on top of recent "packages-update" of all Roslyn and Visual Studio packages.
Without it, "build.cmd -testVS" was failing in latest Int Preview version of visual studio.