Skip to content

Check expressions: safer init properties check#13892

Merged
vzarytovskii merged 1 commit intodotnet:mainfrom
auduchinok:chekExpr-minfos
Sep 13, 2022
Merged

Check expressions: safer init properties check#13892
vzarytovskii merged 1 commit intodotnet:mainfrom
auduchinok:chekExpr-minfos

Conversation

@auduchinok
Copy link
Copy Markdown
Member

Fixes #13857.

@vzarytovskii
Copy link
Copy Markdown
Member

Huh, interesting, I've introduced it in #13490, not sure why I've used List.head though.
Probably just because it is used for properties:
https://github.com/dotnet/fsharp/pull/13490/files#diff-abbd2e67118d1b130339772eb817cfeba41f4a56819c69d551049aa949689b61R9045

@auduchinok did you manage to get a smaller repro? Do we know on which code is it throwing?

@auduchinok
Copy link
Copy Markdown
Member Author

auduchinok commented Sep 13, 2022

@auduchinok did you manage to get a smaller repro? Do we know on which code is it throwing?

Nope, it started throwing it on a big solution at some point, so I went to look at the code that throws it.
I've verified the fix on the tests mentioned in #13857, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exception in ParseAndCheckFile when using FCS built in Debug configuration

2 participants