Streamlining some dependencies around Microsoft.CodeAnalysis #13637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzarytovskii
requested changes
Aug 5, 2022
Member
|
Also, please retarget PR to 17.4 branch. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
KevinRansom
approved these changes
Aug 5, 2022
vzarytovskii
approved these changes
Aug 9, 2022
vzarytovskii
pushed a commit
to vzarytovskii/fsharp
that referenced
this pull request
Sep 20, 2022
…13637) * Streamlining dependencies around Microsoft.CodeAnalysis * Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed some weird behavior in some of the test files. The project compiles, but some files show errors:
We briefly discussed this with @KevinRansom, looks like we have code in FSharp.PatternMatcher which effectively duplicates what's already there in Microsoft.CodeAnalysis. So we can remove that and simplify things a bit.
Moreover, turned out we have dependencies on some auxiliary packages which are not meant for direct usage:
This is also fixed here.