Fix culture sensitive tests #13230
Merged
Fix culture sensitive tests #13230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
approved these changes
Jun 3, 2022
vzarytovskii
approved these changes
Jun 3, 2022
Member
vzarytovskii
left a comment
vzarytovskii
left a comment
There was a problem hiding this comment.
Thanks for the fix @thinkbeforecoding, are the tests passing on your locale now, shall we merge it, or do you have any other changes pending?
Contributor
Author
|
You can merge it. |
Contributor
Author
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix culture sensitive tests. Fix #13212
Some tests run FCS in process, in this case it uses the SetUICulture and SetCulture attributes.
For tests that run Fsc or Fsi as an external exe, it adds the --preferreduilang to force the culture.
Some tests still failed because the SR module caches the CurrentUICulture. In Fsi, an early call to SR.GetString is done before changing the culture indicated by the preferreduilang flag, so the local machine's default culture is cached for some error messages instead of using indicated culture. This as been fix by using CurrentUICulture directly.