-
Notifications
You must be signed in to change notification settings - Fork 838
Improve error reporting: Let as last line in block #1164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1e1d6ff to
27c2921
Compare
aee7847 to
412c291
Compare
|
Per other error message discussions, please follow the "Error. Explanation. Suggestion" format. (e.g. Try reading your error message interpreting the first sentence as a description of an error - i.e. a negative - rather than the positive explanation you intend). |
|
Oh, also be careful of using the word Together those two observations would give something like: |
6f671ef to
ea3e6bd
Compare
|
@forki When you update the error message could you update the screen shot too? Or just remove it. Thanks |
|
The code and new message look good to me, it's ready to go (as far as I can see :) ) |
00a117e to
c5ece91
Compare
|
something is strange with appveyor - @KevinRansom @otawfik-ms |
|
it's green and ready |
fixes #1162