Emitting IsReadOnlyAttribute on return arguments of type inref<_>#10022
Merged
cartermp merged 3 commits intodotnet:mainfrom Sep 9, 2020
Merged
Emitting IsReadOnlyAttribute on return arguments of type inref<_>#10022cartermp merged 3 commits intodotnet:mainfrom
cartermp merged 3 commits intodotnet:mainfrom
Conversation
KevinRansom
approved these changes
Sep 1, 2020
Contributor
Author
|
@dsyme this look ok? Wondering if there is an alternative to |
dsyme
reviewed
Sep 4, 2020
|
|
||
| assert witnessInfos.IsEmpty | ||
|
|
||
| let _, retTy = stripFunTy g vref.Type |
Contributor
There was a problem hiding this comment.
I think this will fail for generic methods. Instead, notice that GetMethodSpecForMemberVal is already cracking the returnTy, so return returnTy from that and collect it 4 lines above.
Contributor
|
@TIHan I left a note, there's an easy alternative to using |
Contributor
Author
|
Thanks, I will make those changes. I knew |
dsyme
approved these changes
Sep 9, 2020
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
…tnet#10022) * Emitting IsReadOnlyAttribute on return arguments of type inref<_> * Emitting modreq(InAttribute) on property type and emitting IsReadOnlyAttribute on property * Correctly getting return type. Added more tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves this: #9997 (comment)
Pretty straight forward, though a little awkward due to passing an
ILTypeand aTType.