Backport #7360: Fix CI hang in SqliteVectorStoreWriterTests (data-ingestion-preview2)#7388
Merged
adamsitnik merged 2 commits intodata-ingestion-preview2from Mar 15, 2026
Merged
Conversation
Co-authored-by: adamsitnik <[email protected]>
adamsitnik
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IncrementalIngestion_WithManyRecords_DeletesAllPreExistingChunkswas hanging CI (killed after 5m28s+) due to 2500 individual SQLiteUpsertAsynccalls (~3ms each = ~8s locally, ~37× slower on CI).Changes
VectorStoreWriter.cs: MakeMaxTopCountconfiguration-dependent via conditional compilation —1_000in Release,10in Debug — enabling pagination loop testing without large record sets:VectorStoreWriterTests.cs: Reduce record count from 2500 → 50. WithMaxTopCount=10in Debug, this still exercises 5 pagination iterations while eliminating the scaling concern.Microsoft Reviewers: Open in CodeFlow