Skip to content

Backport #7360: Fix CI hang in SqliteVectorStoreWriterTests (data-ingestion-preview2)#7388

Merged
adamsitnik merged 2 commits intodata-ingestion-preview2from
copilot/backport-fix-from-7360
Mar 15, 2026
Merged

Backport #7360: Fix CI hang in SqliteVectorStoreWriterTests (data-ingestion-preview2)#7388
adamsitnik merged 2 commits intodata-ingestion-preview2from
copilot/backport-fix-from-7360

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 11, 2026

IncrementalIngestion_WithManyRecords_DeletesAllPreExistingChunks was hanging CI (killed after 5m28s+) due to 2500 individual SQLite UpsertAsync calls (~3ms each = ~8s locally, ~37× slower on CI).

Changes

  • VectorStoreWriter.cs: Make MaxTopCount configuration-dependent via conditional compilation — 1_000 in Release, 10 in Debug — enabling pagination loop testing without large record sets:
    const int MaxTopCount =
    #if RELEASE
        1_000;
    #else
        10;
    #endif
  • VectorStoreWriterTests.cs: Reduce record count from 2500 → 50. With MaxTopCount=10 in Debug, this still exercises 5 pagination iterations while eliminating the scaling concern.
Microsoft Reviewers: Open in CodeFlow

@adamsitnik adamsitnik added this to the Data Ingestion Preview 2 milestone Mar 11, 2026
@adamsitnik adamsitnik marked this pull request as ready for review March 15, 2026 08:43
@adamsitnik adamsitnik merged commit 8b00e5b into data-ingestion-preview2 Mar 15, 2026
2 of 6 checks passed
@adamsitnik adamsitnik deleted the copilot/backport-fix-from-7360 branch March 15, 2026 08:43
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants