Update Microsoft.VisualStudio.Threading.Analyzers to latest #7091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Microsoft.VisualStudio.Threading.Analyzers package from version 17.10.48 to 17.14.15 and addresses a new analyzer warning (VSTHRD002) in the FakeHost.Dispose method by adding a pragma warning suppression and removing the ConfigureAwait(false) call.
Key Changes
- Upgraded Microsoft.VisualStudio.Threading.Analyzers from 17.10.48 to 17.14.15
- Suppressed VSTHRD002 warning for synchronous wait in FakeHost.Dispose method
- Removed ConfigureAwait(false) from the synchronous wait pattern
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/packages/General.props | Updated Microsoft.VisualStudio.Threading.Analyzers package version to 17.14.15 |
| src/Libraries/Microsoft.Extensions.Hosting.Testing/FakeHost.cs | Added VSTHRD002 pragma suppression and removed ConfigureAwait(false) from StopAsync call in Dispose method |
evgenyfedorov2
approved these changes
Dec 1, 2025
This was referenced Dec 11, 2025
This was referenced Dec 18, 2025
Closed
Open
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow