Skip to content

Layer enrichment & redaction on top of HttpLogging#4330

Merged
joperezr merged 44 commits intodotnet:release/8.0from
Tratcher:tratcher/httplogging
Oct 9, 2023
Merged

Layer enrichment & redaction on top of HttpLogging#4330
joperezr merged 44 commits intodotnet:release/8.0from
Tratcher:tratcher/httplogging

Conversation

@Tratcher
Copy link
Copy Markdown
Member

@Tratcher Tratcher commented Aug 23, 2023

Consumes the new APIs from dotnet/aspnetcore#50163 to consolidate functionality. The build won't pass until we consume that PR through an updated dependency, but everything builds and tests pass locally.

Fixes #4210 #4492 #4440 #4451

Major changes:

  • Removed redundant types like middleware, request body handling, response body handling, media types, etc.
  • Exception logging is delegated to the ExceptionHandling middleware, but we still log any request data we've accumulated so far.

Now that it's functional, parts of the original design should be revisited like the manual path filtering. We don't want to re-invent routing.

Microsoft Reviewers: Open in CodeFlow

@Tratcher
Copy link
Copy Markdown
Member Author

Tratcher commented Sep 1, 2023

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@Tratcher Tratcher force-pushed the tratcher/httplogging branch from df6c8f4 to a04ba62 Compare September 1, 2023 18:43
@Tratcher Tratcher requested review from geeknoid and xakep139 October 5, 2023 20:59
@Tratcher
Copy link
Copy Markdown
Member Author

Tratcher commented Oct 9, 2023

@geeknoid @iliar-turdushev FYI I've pushed changes to also fix #4451.

@joperezr joperezr merged commit a959ae4 into dotnet:release/8.0 Oct 9, 2023
@Tratcher Tratcher added this to the 8.0-rtm milestone Oct 9, 2023
@Tratcher Tratcher deleted the tratcher/httplogging branch October 9, 2023 20:31
@ghost ghost locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants