DI - Cache CallSiteValidator results during walk #2374
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandondahler
commented
Sep 21, 2019
src/DependencyInjection/DI/src/ServiceLookup/CallSiteValidator.cs
Outdated
Show resolved
Hide resolved
src/DependencyInjection/DI/test/ServiceProviderValidationTests.cs
Outdated
Show resolved
Hide resolved
Author
|
/cc @davidfowl |
brandondahler
commented
Sep 21, 2019
| VisitCallSite(callSite, default); | ||
| } | ||
|
|
||
| protected override Type VisitCallSite(ServiceCallSite callSite, CallSiteValidatorState argument) |
Author
There was a problem hiding this comment.
Nit - rename argument to state.
brandondahler
commented
Sep 23, 2019
| private readonly ConcurrentDictionary<Type, Type> _scopedServices = new ConcurrentDictionary<Type, Type>(); | ||
|
|
||
| // Cache already-checked services that resulted in null. | ||
| private readonly HashSet<Type> _nonScopedServices = new HashSet<Type>(); |
Author
There was a problem hiding this comment.
Should we just be using ServiceCacheKey instead? Same for _scoped services?
|
As per aspnet/Announcements#411, we are currently migrating components from this repository to other repositories. This PR targets components that have been moved to dotnet/runtime, in the src/libraries directory. If you're still interested in contributing this change, please retarget your PR to dotnet/runtime and reference the original issue discussing the change or bug fix. If you have questions, or need guidance on how to port your change, please tag |
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caches the results of CallSiteValidator during its walk
Addresses #2353
Performance Comparison
As measured by CallSiteValidatorBenchmark.cs:
Before
After