Update core-setup version and workaround dotnet/sdk#2976 #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
requested changes
Feb 22, 2019
| @@ -9,7 +9,6 @@ trigger: | |||
| include: | |||
| - master | |||
| - release/* | |||
| - internal/release/* | |||
There was a problem hiding this comment.
Instead make these conditional on the queue e.g. something like
${{ if ne(variables['System.TeamProject'], 'internal') }}:
- release/*
${{ if eq(variables['System.TeamProject'], 'internal') }}:
- internal/release/*There was a problem hiding this comment.
We should not build internal/release/* at all right now. Arcade publishing is not designed to handle this and we do not want to accidentally push internal-only fixes publicly. I'm sending mail about this and will CC you
|
I'm going to use admin rights to merge this so we can kick of upstream updates. @dougbu let's discuss the branch thing separately. It's important for now that we do not build internal/release/*, so I'm leaving that change in. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More dependency flow updates due to re-spins in dotnet/core-setup