Skip to content

Conversation

@Anipik
Copy link

@Anipik Anipik commented Aug 31, 2021

This change add the version suffix to the published blob paths. this is needed to have unique paths for all the multiple builds publishing the same package version to the storage account.

@Anipik Anipik requested a review from mmitche August 31, 2021 22:37
Copy link
Member

@mmitche mmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would name this something different. I think it may have to be used in downstream repos to properly find the emsdk assets, and dummy isn't a great term for it.

I recommend Microsoft.NET.Runtime.Emscripten.Sdk.Internal or something along those lines.

@Anipik Anipik requested a review from mmitche September 1, 2021 17:52
@mmitche mmitche merged commit 9838ec0 into dotnet:release/6.0 Sep 1, 2021
@akoeplinger
Copy link
Member

please port this to main if it's complete :)

akoeplinger pushed a commit that referenced this pull request Sep 3, 2021
) (#72)

This change add the version suffix to the published blob paths. this is needed to have unique paths for all the multiple builds publishing the same package version to the storage account.

Port of #71

Co-authored-by: Matt Mitchell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants