[main] [wasm-mt] Create a Microsoft.NET.Runtime.Emscripten.Cache#211
Merged
lewing merged 1 commit intodotnet:mainfrom Sep 9, 2022
Merged
[main] [wasm-mt] Create a Microsoft.NET.Runtime.Emscripten.Cache#211lewing merged 1 commit intodotnet:mainfrom
lewing merged 1 commit intodotnet:mainfrom
Conversation
Spin out the emscripten system libraries cache into a separate nupkg. - Split up the Emscripten SDK by moving the system libraries cache into a separate nupkg. - make a new Emscripten Cache SDK that includes just the cache directory - the Cache SDK overrides the WasmCachePath (if it's not set by the user) to point into the Cache SDK we leave the mt multithreaded libraries in the cache. (But we remove the ww WebWorker (non-pthread) Emscripten API libraries) Addresses dotnet/runtime#75263
Member
Author
|
@lewing the cherry-pick applied cleanly; I guess there's no net8 workload yet? |
lewing
approved these changes
Sep 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a forward port of #208 to
mainSpin out the emscripten system libraries cache into a separate nupkg.
Split up the Emscripten SDK by moving the system libraries cache into a separate nupkg.
make a new Emscripten Cache SDK that includes just the cache directory
the Cache SDK overrides the WasmCachePath (if it's not set by the user) to point into the Cache SDK
we leave the mt multithreaded libraries in the cache. (But we remove the ww WebWorker (non-pthread) Emscripten API libraries)
Addresses dotnet/runtime#75263