Skip to content

Conversation

@lewing
Copy link
Member

@lewing lewing commented Feb 9, 2022

No description provided.

@lewing lewing requested a review from steveisok February 9, 2022 17:52
@lewing
Copy link
Member Author

lewing commented Feb 9, 2022

looks like this is confusing the packaging steps a bit

@lewing
Copy link
Member Author

lewing commented Feb 11, 2022

@joeloff just a heads up that this is something we may need to be able to package as well, it's reusing the same pack for win-x64 and win-arm64 which seems to be confusing the tooling

@joeloff
Copy link
Member

joeloff commented Feb 11, 2022

I tested locally and it's finding all the files. The change seems fine as we should be extracting the package content once and then harvesting it multiple times for the different MSI flavors we produce.

@joeloff
Copy link
Member

joeloff commented Feb 11, 2022

It's literally missing a few files in what appears to be random folders. I'll take a look at the bin logs and see if anything useful is logged.

@joeloff
Copy link
Member

joeloff commented Feb 11, 2022

OK, this is odd, it seems to be extracting the packages multiple times while building, which can explain why some files are disappearing.

@joeloff
Copy link
Member

joeloff commented Feb 11, 2022

Think I know what's happening. You need to use Arcade 7.0.0-beta.22106.1 or later (that has the fix to dedupe packages and is the issue you're running into right now)

@lewing
Copy link
Member Author

lewing commented Feb 12, 2022

I hadn't noticed main didn't have the arcade bump yet. Sorry for the noise

@joeloff
Copy link
Member

joeloff commented Feb 12, 2022

No worries, we're making a lot of changes to how we generate workloads, so it's good to double check in case we missed anything

@akoeplinger
Copy link
Member

main should have latest arcade now: #110

@lewing lewing marked this pull request as ready for review March 23, 2022 17:40
@lewing lewing merged commit 9115280 into dotnet:main Mar 24, 2022
@lewing lewing deleted the win-arm64-emu branch March 24, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants