Skip to content

Switch Microsoft.Data.Sqlite and EFCore.Sqlite to SQLite3MC.PCLRaw.bundle#38402

Merged
AndriySvyryd merged 3 commits into
mainfrom
copilot/change-sqlite-dependency
Jun 15, 2026
Merged

Switch Microsoft.Data.Sqlite and EFCore.Sqlite to SQLite3MC.PCLRaw.bundle#38402
AndriySvyryd merged 3 commits into
mainfrom
copilot/change-sqlite-dependency

Conversation

Copilot AI commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Changes the Microsoft.Data.Sqlite and Microsoft.EntityFrameworkCore.Sqlite packages to bundle SQLite3MC.PCLRaw.bundle instead of SQLitePCLRaw.bundle_e_sqlite3, giving shipped consumers a native SQLite build with encryption (SQLite3 Multiple Ciphers) by default, and updates the SQLite benchmarks to use the same bundle.

Changes

  • Product dependenciessrc/Microsoft.Data.Sqlite/Microsoft.Data.Sqlite.csproj and src/EFCore.Sqlite/EFCore.Sqlite.csproj now reference SQLite3MC.PCLRaw.bundle.
  • Benchmark dependencybenchmark/EFCore.Sqlite.Benchmarks/EFCore.Sqlite.Benchmarks.csproj now references SQLite3MC.PCLRaw.bundle.
  • Package version plumbing — moved the SQLite3MC.PCLRaw.bundle PackageVersion from test/Directory.Packages.props up to the root Directory.Packages.props so non-test product projects resolve it, removed the duplicate test entry, and updated $(SQLite3MCPCLRawBundleVersion) to 2.3.5 in eng/Versions.props.

Test coverage

No structural test change required — the existing Microsoft.Data.Sqlite provider matrix still exercises both bundles via separate projects and DefineConstants:

  • Microsoft.Data.Sqlite.TestsE_SQLITE3 / SQLitePCLRaw.bundle_e_sqlite3
  • Microsoft.Data.Sqlite.sqlite3mc.TestsSQLITE3MC / SQLite3MC.PCLRaw.bundle

Targeted validation also restores and builds the updated EFCore.Sqlite and EFCore.Sqlite.Benchmarks projects against the new bundle.

Notes

  • This change updates the shipped Microsoft.Data.Sqlite and Microsoft.EntityFrameworkCore.Sqlite packages, plus the SQLite benchmark project, to use SQLite3MC by default.
  • Several test-only projects intentionally continue to reference bundle_e_sqlite3 to preserve existing provider coverage.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Microsoft.Data.Sqlite meta-package to depend on the SQLite3 Multiple Ciphers (SQLite3MC) bundle by default, and moves the corresponding central package version to the repo root so the product project can resolve it.

Changes:

  • Switched src/Microsoft.Data.Sqlite/Microsoft.Data.Sqlite.csproj from SQLitePCLRaw.bundle_e_sqlite3 to SQLite3MC.PCLRaw.bundle.
  • Moved the central PackageVersion for SQLite3MC.PCLRaw.bundle from test/Directory.Packages.props to the root Directory.Packages.props and removed the duplicate test-only entry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
test/Directory.Packages.props Removes the test-local central version entry now that the version is defined at the repo root.
src/Microsoft.Data.Sqlite/Microsoft.Data.Sqlite.csproj Changes the meta-package dependency to SQLite3MC.PCLRaw.bundle so consumers get SQLite3MC by default.
Directory.Packages.props Adds the central version entry for SQLite3MC.PCLRaw.bundle to support product builds.

@AndriySvyryd
AndriySvyryd marked this pull request as ready for review June 10, 2026 21:32
@AndriySvyryd
AndriySvyryd requested a review from a team as a code owner June 10, 2026 21:32
@AndriySvyryd
AndriySvyryd requested a review from SamMonoRT June 10, 2026 21:33
@AndriySvyryd

Copy link
Copy Markdown
Member

@artl93 @jeffhandley @ViveliDuCh FYI

Comment thread Directory.Packages.props
Copilot AI requested a review from wtgodbe as a code owner June 12, 2026 01:35
Copilot AI requested a review from AndriySvyryd June 12, 2026 01:35
Comment thread src/Microsoft.Data.Sqlite/Microsoft.Data.Sqlite.csproj
Copilot AI requested review from Copilot and removed request for Copilot June 12, 2026 01:42
Copilot AI changed the title Switch Microsoft.Data.Sqlite to SQLite3MC.PCLRaw.bundle Switch Microsoft.Data.Sqlite and EFCore.Sqlite to SQLite3MC.PCLRaw.bundle Jun 12, 2026
Copilot AI requested a review from AndriySvyryd June 12, 2026 01:43
@AndriySvyryd
AndriySvyryd merged commit f9105a5 into main Jun 15, 2026
14 checks passed
@AndriySvyryd
AndriySvyryd deleted the copilot/change-sqlite-dependency branch June 15, 2026 19:14
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 11.0-preview6 milestone Jun 16, 2026
Aaronontheweb added a commit to Aaronontheweb/akka.net that referenced this pull request Jun 22, 2026
Pin SQLitePCLRaw.lib.e_sqlite3 to 3.50.3 was rejected because it's an
unlisted version. Instead, add NuGetAuditSuppress for GHSA-2m69-gcr7-jv3q
(CVE-2025-6965) to the affected example projects, matching the approach
used in netclaw-dev/netclaw#1444.

Upstream fix tracking:
- dotnet/efcore#38402
Aaronontheweb added a commit to akkadotnet/akka.net that referenced this pull request Jun 22, 2026
…8278)

* fix: suppress GHSA-2m69-gcr7-jv3q in SQLite-backed example projects

Pin SQLitePCLRaw.lib.e_sqlite3 to 3.50.3 was rejected because it's an
unlisted version. Instead, add NuGetAuditSuppress for GHSA-2m69-gcr7-jv3q
(CVE-2025-6965) to the affected example projects, matching the approach
used in netclaw-dev/netclaw#1444.

Upstream fix tracking:
- dotnet/efcore#38402

* fix: move NuGetAuditSuppress into ItemGroup (MSBuild syntax)

<NuGetAuditSuppress> requires an ItemGroup wrapper, not PropertyGroup.
This was causing build failures for both SQLite-backed example projects.

* fix: add NuGetAuditSuppress to Akka.Persistence.Custom.Tests

The full solution build revealed a third SQLite-backed project that also
needs the GHSA-2m69-gcr7-jv3q suppress: Akka.Persistence.Custom.Tests.
Aaronontheweb added a commit to Aaronontheweb/akka.net that referenced this pull request Jun 22, 2026
Pin SQLitePCLRaw.lib.e_sqlite3 to 3.50.3 was rejected because it's an
unlisted version. Instead, add NuGetAuditSuppress for GHSA-2m69-gcr7-jv3q
(CVE-2025-6965) to the affected example projects, matching the approach
used in netclaw-dev/netclaw#1444.

Upstream fix tracking:
- dotnet/efcore#38402
Aaronontheweb added a commit to akkadotnet/akka.net that referenced this pull request Jun 22, 2026
* fix: add NuGetAuditSuppress to Akka.Persistence.Custom.Tests

The full solution build revealed a third SQLite-backed project that also
needs the GHSA-2m69-gcr7-jv3q suppress: Akka.Persistence.Custom.Tests.

* fix: move NuGetAuditSuppress into ItemGroup (MSBuild syntax)

<NuGetAuditSuppress> requires an ItemGroup wrapper, not PropertyGroup.
This was causing build failures for both SQLite-backed example projects.

* fix: suppress GHSA-2m69-gcr7-jv3q in SQLite-backed example projects

Pin SQLitePCLRaw.lib.e_sqlite3 to 3.50.3 was rejected because it's an
unlisted version. Instead, add NuGetAuditSuppress for GHSA-2m69-gcr7-jv3q
(CVE-2025-6965) to the affected example projects, matching the approach
used in netclaw-dev/netclaw#1444.

Upstream fix tracking:
- dotnet/efcore#38402

* fix: remove duplicate NuGetAuditSuppress from PropertyGroup

<NuGetAuditSuppress> must only be in <ItemGroup>, not <PropertyGroup>.
This was causing MSBuild errors for Akka.Persistence.Custom and
ClusterSharding.Node example projects.
@MichelZ MichelZ mentioned this pull request Jun 23, 2026
ViveliDuCh added a commit to ViveliDuCh/efcore that referenced this pull request Jun 27, 2026
ViveliDuCh added a commit to ViveliDuCh/efcore that referenced this pull request Jun 27, 2026
ViveliDuCh added a commit to ViveliDuCh/efcore that referenced this pull request Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants