Skip to content

Stop using env in copilot-setup-steps.yml#37505

Merged
roji merged 1 commit intodotnet:mainfrom
roji:LastCopilotTweak
Jan 13, 2026
Merged

Stop using env in copilot-setup-steps.yml#37505
roji merged 1 commit intodotnet:mainfrom
roji:LastCopilotTweak

Conversation

@roji
Copy link
Member

@roji roji commented Jan 13, 2026

Because not supported

Continues #37499 and #37497.

@roji roji requested a review from a team as a code owner January 13, 2026 21:09
Copilot AI review requested due to automatic review settings January 13, 2026 21:09
@roji roji enabled auto-merge (squash) January 13, 2026 21:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Copilot setup workflow to avoid using the job-level env block, which is not supported in this context. The environment variable for the SQL Server connection string is now exported in a step using $GITHUB_ENV instead.

Changes:

  • Removed job-level env block containing MSSQL_SA_PASSWORD and Test__SqlServer__DefaultConnection
  • Changed SA_PASSWORD in the SQL Server service container to use the password directly instead of referencing an environment variable
  • Replaced the dummy step with a meaningful step that exports the connection string to $GITHUB_ENV for use by the agent
  • Updated documentation comment from "Based on" to "See"

@roji roji merged commit a9895a5 into dotnet:main Jan 13, 2026
17 checks passed
@roji roji deleted the LastCopilotTweak branch January 13, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants