[release/10.0] Correct [DynamicDependency] reference on ExecuteUpdateAsync (#37194)#37359
Merged
roji merged 1 commit intodotnet:release/10.0from Dec 20, 2025
Merged
Conversation
…7194) Fixes dotnet#37192 (cherry picked from commit 7efce7b)
AndriySvyryd
approved these changes
Dec 16, 2025
artl93
approved these changes
Dec 18, 2025
Member
artl93
left a comment
artl93
left a comment
There was a problem hiding this comment.
Customer reported regression. Approved.
Are there integration tests for this type of thing?
Member
Author
We have some minimal trimming tests, but nothing exhaustive unfortunately... I think that when we set our sights on proper NativeAOT support, part of that will have to be establishing good coverage for this kind of thing. |
Member
Author
|
Approved via email. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37192
Description
In EF 10, ExecuteUpdate received improvements to make it easier to use in dynamic scenarios. Unfortunately, the [DynamicDependency] attribute set on it - which helps users who trim their applications - wasn't specified correctly.
Customer impact
Users upgrading to 10 and using ExecuteUpdateAsync and using trimming get a linker warning because of the mangled [DynamicDependency], and their application may not work correctly.
How found
Multiple customers reported on 10.0.
Regression
Yes.
Testing
Trimming annotation issue, testing is impractical.
Risk
Almost non-existent, fix to [DynamicDependency] attribute only.