[rc2] Allow the build host to be copied from M.CA.Workspaces.MSBuild#36708
Merged
AndriySvyryd merged 1 commit intorelease/10.0from Sep 5, 2025
Merged
[rc2] Allow the build host to be copied from M.CA.Workspaces.MSBuild#36708AndriySvyryd merged 1 commit intorelease/10.0from
AndriySvyryd merged 1 commit intorelease/10.0from
Conversation
artl93
approved these changes
Sep 4, 2025
roji
approved these changes
Sep 4, 2025
Member
Author
If the user uses |
AndriySvyryd
force-pushed
the
Issue35638
branch
from
3063ab1 to
2dd1b8a
Compare
Add more diagnostic information on MSBuild workspace failure Remove MSBuildLocator usage as it's no longer needed Fixes #35638
AndriySvyryd
force-pushed
the
Issue35638
branch
from
2dd1b8a to
5acd39a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #35638
Description
Microsoft.CodeAnalysis.Workspaces.MSBuildlooks for the build host in the user's project, but it's not present as by defaultcontentis not transitively used from NuGet packages. This PR fixes that and adds more diagnostic information on MSBuild workspace failures.MSBuildLocatorusage is also removed as it's no longer needed with the current version ofMicrosoft.CodeAnalysis.Workspaces.MSBuild.Customer impact
Customers using
Microsoft.EntityFrameworkCore.Tasksto precompile queries will get an exception on build/publish. The only workaround is to use other tools instead.How found
Found during validation.
Regression
Yes, from EF 9.0.x
Testing
Tested manually.
Risk
Low, the code change only affects the broken scenario.