Merged
Conversation
SamMonoRT
reviewed
Jan 16, 2025
| <file src="$OutputPath$$DefaultNetCoreTargetFramework$\$AssemblyName$.deps.json" target="tasks\$DefaultNetCoreTargetFramework$\" /> | ||
| <file src="$OutputPath$net472\*" target="tasks\net472\" /> | ||
| <file src="$ArtifactsBinDir$ef\$Configuration$\netcoreapp2.0\*" target="tools\netcoreapp2.0\" /> | ||
| <file src="$ArtifactsBinDir$ef\$Configuration$\$DefaultNetCoreTargetFramework$\*" target="tools\$DefaultNetCoreTargetFramework$\" /> |
Member
There was a problem hiding this comment.
Trying to understand why do we need this now, and how does this play into versioning with Aspire etc?
Member
Author
There was a problem hiding this comment.
- netcoreapp2.0 is very out of support and this is being flagged by NuGet Audit
- We need to target net9.0 or newer to be able to fix React to deps.json change wrt PrivateAssets #35265
- This is a significant change, so it's best to be done early in the release
Member
Author
There was a problem hiding this comment.
This means that the user project will need to target net10.0 to be able to refence and use our tools.
AndriySvyryd
force-pushed
the
Issue34654
branch
from
ed04c71 to
2f60c36
Compare
SamMonoRT
approved these changes
Jan 17, 2025
AndriySvyryd
force-pushed
the
Issue34654
branch
from
2f60c36 to
611de6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34654