Merged
Conversation
roji
force-pushed
the
QueryParameters
branch
2 times, most recently
from
9175213 to
3d9c8c4
Compare
roji
commented
Nov 14, 2024
| { | ||
| Name = name; | ||
| Type = type; | ||
| ShouldBeConstantized = shouldBeConstantized; |
Member
Author
There was a problem hiding this comment.
For the record I am not in love with these names
Member
Author
There was a problem hiding this comment.
We'll pick this up again in API design ;)
roji
force-pushed
the
QueryParameters
branch
from
3d9c8c4 to
efe1458
Compare
cincuranet
approved these changes
Nov 19, 2024
| { | ||
| Name = name; | ||
| Type = type; | ||
| ShouldBeConstantized = shouldBeConstantized; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35089