Add quotability to all SQL expression types#33210
Merged
roji merged 1 commit intodotnet:mainfrom Mar 6, 2024
Merged
Conversation
maumar
approved these changes
Mar 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the next building block in the precompiled query story: this adds quoting functionality (
Quote()) to all nodes which can appear in the SQL tree (see #33008 for more background). Although large, this PR is pretty straightforward, just adding the proper functionality to all nodes.Note that I'm working on good testing infra in parallel, but as it's end-to-end testing, it depends on various things that are still to come (e.g. actually generating the interceptors etc.). If interested, check out https://github.com/roji/efcore/blob/PrecompiledQueries/test/EFCore.Relational.Specification.Tests/Query/PrecompiledQueryRelationalTestBase.cs#L14, which is where the ongoing work on the tests is happening. We'll definitely have to do another pass at some point to verify that everything is properly covered.
Closes #33008