Scaffolding Change -d option to -m, since -d no longer works#32606
Merged
ajcvickers merged 1 commit intomainfrom Dec 14, 2023
Merged
Scaffolding Change -d option to -m, since -d no longer works#32606ajcvickers merged 1 commit intomainfrom
ajcvickers merged 1 commit intomainfrom
Conversation
This has been broken form 6 onwards. It's possible the tools will revert their break, but there doesn't seem much value in keeping -d at this point. -m stands for "mapping attributes" ¯\_(``)_/¯ Fixes #26687
Contributor
|
Breaking change? Or already too broken? |
Contributor
Author
|
It's only a breaking change when moving from an unsupported version. |
AndriySvyryd
approved these changes
Dec 13, 2023
Member
AndriySvyryd
left a comment
AndriySvyryd
left a comment
There was a problem hiding this comment.
Is it possible to add tests that would fail if one of the options is broken in this way again?
ajcvickers
added a commit
that referenced
this pull request
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been broken form 6 onwards. It's possible the tools will revert their break, but there doesn't seem much value in keeping -d at this point.
-m stands for "mapping attributes" ¯_(``)_/¯
Fixes #26687