Update tool to roll forward to latest major version of runtime installed.#27671
Merged
ajcvickers merged 1 commit intodotnet:mainfrom Mar 28, 2022
Merged
Update tool to roll forward to latest major version of runtime installed.#27671ajcvickers merged 1 commit intodotnet:mainfrom
ajcvickers merged 1 commit intodotnet:mainfrom
Conversation
AraHaan
changed the title
AraHaan
force-pushed
the
patch-2
branch
2 times, most recently
from
ec7fe33 to
c876901
Compare
Member
Author
|
Welp just tested these changes and it looks like there is 1 more place where it expects ef.dll in Edit: found it just now. |
AraHaan
force-pushed
the
patch-2
branch
2 times, most recently
from
137eda5 to
7aeb4a7
Compare
Member
Author
|
cc: @roji, @ajcvickers does this look good to you on the fix for my issue? |
3 tasks
bricelam
suggested changes
Mar 22, 2022
Contributor
bricelam
left a comment
bricelam
left a comment
There was a problem hiding this comment.
Most of these changes seem unnecessary and won't actually address the issue you're seeing.
…led. This is needed otherwise it will try to require ".NET 2.0 Runtime" to be installed, which will cause roll forward to fail to load 6.0.0's System.Runtime when used on devices with newer versions of the .NET SDK and runtimes. Fixes: dotnet#27660. Signed-off-by: AraHaan <[email protected]>
AraHaan
changed the title
Member
Author
|
The change works. |
Member
Author
|
@bricelam I have completed the requested changes and verified that they work still on fixing the issue. |
Member
Author
|
Now the github actions check should be rerun and it should pass. |
Contributor
|
Merged following team review. Cosmos failure was a known issue. Thanks @AraHaan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed otherwise it will try to require ".NET 2.0 Runtime" to be installed, which will cause roll forward to fail to load 6.0.0's System.Runtime when used on devices with newer versions of the .NET SDK and runtimes.
Fixes: #27660.
Discovered at: #27660 (comment)