Stop using GetRequired* reflection wrappers to enable trimming#27099
Merged
roji merged 5 commits intodotnet:mainfrom Jan 8, 2022
Merged
Stop using GetRequired* reflection wrappers to enable trimming#27099roji merged 5 commits intodotnet:mainfrom
roji merged 5 commits intodotnet:mainfrom
Conversation
Contributor
|
If it is not a test project, I would recommend updating azure-pipelines.yml to add additional step which runs this console app. You can also create batch file or sh file to build run it (so yml file will have single command invocation) |
roji
force-pushed
the
GetRequiredRuntimeStuff
branch
6 times, most recently
from
799e204 to
8bd58b8
Compare
roji
force-pushed
the
GetRequiredRuntimeStuff
branch
from
8bd58b8 to
1968694
Compare
AndriySvyryd
approved these changes
Jan 8, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes GetRequiredRuntimeMethod and similar wrappers (introduced during NRT annotation), since these are opaque to the linker when performing static analysis for trimming; the reflection APIs are called directly instead.
A console program is included as a regression test - to test it, execute
dotnet publish -c Release -r linux-x64 --self-containedunder test/EFCore.Trimming.Test and then attempt to run EFCore.Trimming.Test from the publish directory.Assuming we want to add this to our CI pipeline, @smitpatel where would be the right place to add it? Just an additional step e.g. under Linux in azure-pipelines.yml?
Note #27098 which provides a hacky but much smaller fix for 6.0.
Fixes #26288