Skip to content

Use new Hosted build pools #25807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smitpatel merged 1 commit into from
Sep 1, 2021
Merged

Use new Hosted build pools #25807

smitpatel merged 1 commit into from
Sep 1, 2021

Conversation

@ulisesh
Copy link
Contributor

@ulisesh ulisesh commented Aug 31, 2021

We are transitioning all servicing build to a new set of pools

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

@ulisesh ulisesh requested a review from smitpatel September 1, 2021 00:03
smitpatel
smitpatel approved these changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tagging @dotnet/aspnet-build

Also may need to do the same update in https://github.com/dotnet/efcore/blob/0ba16959c7c4f38f9162101966a6f863ba707120/azure-pipelines-richnav.yml

@ulisesh
Copy link
Contributor Author

ulisesh commented Sep 1, 2021

It looks like I don't have enough permissions to merge, @smitpatel could you please merge this PR?

@TanayParikh
Copy link
Contributor

TanayParikh commented Sep 1, 2021

I don't have context on this change, going to wait for @dougbu / @wtgodbe to comment/merge.

@smitpatel
Copy link
Contributor

smitpatel commented Sep 1, 2021

Waiting from someone from build team to take a look also. I can merge after approval.

@TanayParikh
Copy link
Contributor

TanayParikh commented Sep 1, 2021

I can merge after approval.

Oh got it, thought you were requesting someone with admin rights to merge 😄

@smitpatel smitpatel merged commit 86a6983 into dotnet:release/5.0 Sep 1, 2021
This was referenced Sep 3, 2021
Closed
Closed
@dougbu dougbu added this to the 5.0.x milestone Oct 5, 2021
@smitpatel smitpatel removed this from the 5.0.x milestone May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@smitpatel smitpatel smitpatel approved these changes

@dougbu dougbu dougbu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-infrastructure tell-mode

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ulisesh @TanayParikh @smitpatel @dougbu