Use scoped query logger from QueryContext#21024
Merged
Conversation
Resolves #21016 All scoped services used while executing the query comes from QueryContext. All scoped services on QueryCompilationContext should only be used while compiling the query and should not be made part of QueryExecutorLambda. Singleton services comes from QueryCompilationContext and added to the QueryExecutorLambda directly during compilation.
ajcvickers
approved these changes
May 22, 2020
Closed
Contributor
|
@smitpatel Please prepare a PR for 3.1 once this merges to master. |
smitpatel
added a commit
that referenced
this pull request
May 22, 2020
Resolves #21016 All scoped services used while executing the query comes from QueryContext. All scoped services on QueryCompilationContext should only be used while compiling the query and should not be made part of QueryExecutorLambda. Singleton services comes from QueryCompilationContext and added to the QueryExecutorLambda directly during compilation. Cherry-pick of #21024 on release/3.1
smitpatel
added a commit
that referenced
this pull request
May 22, 2020
Resolves #21016 All scoped services used while executing the query comes from QueryContext. All scoped services on QueryCompilationContext should only be used while compiling the query and should not be made part of QueryExecutorLambda. Singleton services comes from QueryCompilationContext and added to the QueryExecutorLambda directly during compilation. Cherry-pick of #21024 on release/3.1
smitpatel
added a commit
that referenced
this pull request
Jun 10, 2020
Resolves #21016 All scoped services used while executing the query comes from QueryContext. All scoped services on QueryCompilationContext should only be used while compiling the query and should not be made part of QueryExecutorLambda. Singleton services comes from QueryCompilationContext and added to the QueryExecutorLambda directly during compilation. Cherry-pick of #21024 on release/3.1
smitpatel
added a commit
that referenced
this pull request
Jun 10, 2020
Resolves #21016 All scoped services used while executing the query comes from QueryContext. All scoped services on QueryCompilationContext should only be used while compiling the query and should not be made part of QueryExecutorLambda. Singleton services comes from QueryCompilationContext and added to the QueryExecutorLambda directly during compilation. Cherry-pick of #21024 on release/3.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #21016
All scoped services used while executing the query comes from QueryContext.
All scoped services on QueryCompilationContext should only be used while compiling the query and should not be made part of QueryExecutorLambda.
Singleton services comes from QueryCompilationContext and added to the QueryExecutorLambda directly during compilation.