Query: Introduce custom query root for TVF#20165
Merged
smitpatel merged 1 commit intosmit/queryrootpart2from Mar 4, 2020
Merged
Query: Introduce custom query root for TVF#20165smitpatel merged 1 commit intosmit/queryrootpart2from
smitpatel merged 1 commit intosmit/queryrootpart2from
Conversation
- Avoids having to do special processing in other visitors - Visit's method's argument correctly in other visitor (this means that if there is a navigation expansion required for a parameter it will be done automatically) - Remove Nav expansion factory not needed anymore - Rename ExpressionPrinter.VisitList to VisitCollection and take IReadOnlyCollection, that is what most expression uses. - Remove unnecessary exception message. They are part of a larger work item. Resolves #20146
Contributor
Author
|
@roji - Can you take a look at this branch and see if you still need fix for the convert node removal work you did in the other PR? |
Member
|
@smitpatel confirmed that with your branch all my tests are green, thanks! |
maumar
reviewed
Mar 4, 2020
test/EFCore.Relational.Specification.Tests/Query/UdfDbFunctionTestBase.cs
Show resolved
Hide resolved
maumar
reviewed
Mar 4, 2020
test/EFCore.Relational.Specification.Tests/Query/UdfDbFunctionTestBase.cs
Show resolved
Hide resolved
maumar
approved these changes
Mar 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #20146