Update nullability convention to new nullability metadata (for preview7) #16403
Conversation
roji
changed the title
|
@dougbu let me know how you want to do this. This is a PR directly against the preview7 branch, if you prefer to submit another |
|
Let's close this because I've cherry-picked the changes into #16394 already and we should keep the compiler update and needed reactions together. (Bit surprised this validated successfully without the compiler updates.) |
This is because the new nullability metadata logic is actually a superset of the old one - the NullableAttributes produced by the old compiler are still recognized properly by the new logic. In retrospect there was no real need to merge this and the compiler change in the same PR etc. |
See https://github.com/dotnet/roslyn/blob/master/docs/features/nullable-metadata.md.
Makes #16370 pass.
/cc @ajcvickers @dougbu