Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/efcore
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5ff0dcb
Choose a base ref
...
head repository: dotnet/efcore
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f3fc0ce
Choose a head ref
  • 1 commit
  • 22 files changed
  • 1 contributor

Commits on Mar 25, 2021

  1. Don't detect public service properties in hierarchy as duplicates (#2… 

    …4462)

* Don't detect public service properties in hierarchy as duplicates

Fixes #23968

Service properties are most commonly private. We were missing test coverage for public service properties in a type hierarchy, which was hiding this bug where we detect the property reflected from the base type as a duplicate. Fix is to match duplicates by name.

Modification: Updated to handle duplicates rather than prevent them.
    @ajcvickers
    ajcvickers authored Mar 25, 2021
    Configuration menu
    Copy the full SHA
    f3fc0ce View commit details
    Browse the repository at this point in the history
Loading