Add support for Asp.net triggers #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 20, 2021
kelltrick
approved these changes
Sep 21, 2021
| return _eventPipeTriggerFactory.Create(endpointInfo, aspnetTriggerSourceConfiguration, _traceEventTriggerFactory, settings, callback); | ||
| } | ||
|
|
||
| private static StatusCodeRange ParseRange(string range) |
Contributor
There was a problem hiding this comment.
I think this is a good start but I imagine we may want to expand this syntax to support something like: 200,202-204
Contributor
There was a problem hiding this comment.
Each item in the StatusCodes property above represents either a single code or a code range. An individual item should not have a combination of them. So this is permissable:
[ "200", "202-204" ]but not:
[ "200,202-204" ]
Member
Author
There was a problem hiding this comment.
I will leave it as is for now, but if there's strong favor for having the payload be one string I can change it.
jander-msft
approved these changes
Sep 21, 2021
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wiktork
force-pushed
the
dev/wiktork/aspnetTriggers
branch
from
6916c7f to
e29a058
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on dotnet/diagnostics#2592