Sample: Use default bin and obj directories locally#1033
Sample: Use default bin and obj directories locally#1033MichaelSimons merged 2 commits intodotnet:masterfrom bricelam:dotnet-ef
Conversation
Changing BaseIntermediateOutputPath prevents "dotnet ef" from working. Resolves dotnet/efcore#12220
|
@richlander Can this get merged? Is there someone else who should review? |
|
Is everyone satisfied with the guidance in the readmes (https://github.com/dotnet/dotnet-docker/blob/master/samples/dotnetapp/dotnet-docker-dev-in-container.md#requirements & https://github.com/dotnet/dotnet-docker/blob/master/samples/aspnetapp/aspnet-docker-dev-in-container.md#requirements)? The guidance is rather open-ended. If there are problems/drawbacks with changing the local bin/obj, perhaps the wording should be adjusted to specifically call out you should only change the container bin/obj path.
|
|
@richlander @MichaelSimons Any update? Can this get merged? |
|
@ajcvickers - Do you have thoughts on the question I posed (#1033 (comment))? I am of the opinion the readme should be updated as well per this change. |
|
@MichaelSimons I have no opinion on that; who would be able to make a call as to whether this is needed or not? |
|
@ajcvickers has anyone tested if a "local" build will overwrite the "container" folder? - the two builds need to coexist without interfering... |
@MichaelSimons yes, I think it is a good idea to reflect this change in the guidance as well. Are you asking that @bricelam makes this changes also in the PR or can you do it after this after it is merged? |
|
The guidance and code should be in sync otherwise the samples are not coherant. I think it could be as simple as making the following tweak to the two readmes ((https://github.com/dotnet/dotnet-docker/blob/master/samples/dotnetapp/dotnet-docker-dev-in-container.md#requirements & https://github.com/dotnet/dotnet-docker/blob/master/samples/aspnetapp/aspnet-docker-dev-in-container.md#requirements)). |
So the guidance only talks about redirecting bin and obj folders for container, as suggested in dotnet#1033 (comment).
It won't. The output assemblies will be like this. There won't be any overlap.
|
| This approach relies on [volume mounting](https://docs.docker.com/engine/admin/volumes/volumes/) (that's the `-v` argument in the following commands) to mount source into the container (without using a Dockerfile). You may need to [Enable shared drives (Windows)](https://docs.docker.com/docker-for-windows/#shared-drives) or [file sharing (macOS)](https://docs.docker.com/docker-for-mac/#file-sharing) first. | ||
|
|
||
| To avoid conflicts between container usage and your local environment, you need to use a different set of `obj` and `bin` folders for each environment. | ||
| To avoid conflicts between container usage and your local environment, you need to use a different set of `obj` and `bin` folders for your container environment. |
There was a problem hiding this comment.
The wording was different there, and it still made sense to me the way it was...
* Use default bin and obj directories locally Changing BaseIntermediateOutputPath prevents "dotnet ef" from working. Resolves dotnet/efcore#12220 * Update dotnet-docker-dev-in-container.md
* Use default bin and obj directories locally Changing BaseIntermediateOutputPath prevents "dotnet ef" from working. Resolves dotnet/efcore#12220 * Update dotnet-docker-dev-in-container.md
Changing
BaseIntermediateOutputPathprevents "dotnet ef" from working.Resolves dotnet/efcore#12220
cc @richlander @divega @ajcvickers