missing docs for System.Runtime.InteropServices.JavaScript#8436
Merged
gewarren merged 2 commits intodotnet:mainfrom Sep 27, 2022
Merged
missing docs for System.Runtime.InteropServices.JavaScript#8436gewarren merged 2 commits intodotnet:mainfrom
gewarren merged 2 commits intodotnet:mainfrom
Conversation
- generate missing doc from the runtime repo
This comment was marked as outdated.
This comment was marked as outdated.
gewarren
approved these changes
Sep 27, 2022
Contributor
|
Oh sorry, I thought you were just re-requesting review from docs. Is it okay that I merged it? |
Member
Author
|
Yes :) |
Contributor
Unfortunately that won't work, @pavelsavara. The docs porting tool only ports new documentation (when the dotnet-api-docs xml elements have the If you want to bring your triple slash comments to dotnet-api-docs, you'll have to manually edit the files. |
Contributor
|
I think Pavel is going in the opposite direction (dotnet-api-docs -> runtime repo). |
Contributor
|
Ah, good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Together with dotnet/runtime#76196