Skip to content

missing docs for System.Runtime.InteropServices.JavaScript#8436

Merged
gewarren merged 2 commits intodotnet:mainfrom
pavelsavara:javascript_api_doc
Sep 27, 2022
Merged

missing docs for System.Runtime.InteropServices.JavaScript#8436
gewarren merged 2 commits intodotnet:mainfrom
pavelsavara:javascript_api_doc

Conversation

@pavelsavara
Copy link
Member

  • add missing summary for the namespace
  • generate missing doc from the runtime repo

Together with dotnet/runtime#76196

- generate missing doc from the runtime repo
@opbld32

This comment was marked as outdated.

@opbld31
Copy link

opbld31 commented Sep 27, 2022

Docs Build status updates of commit 98dab11:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-System.Runtime.InteropServices.JavaScript.xml ✅Succeeded View
xml/System.Runtime.InteropServices.JavaScript/JSFunctionBinding.xml ✅Succeeded View
xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument.xml ✅Succeeded View
xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToJSCallback`1.xml ✅Succeeded View
xml/System.Runtime.InteropServices.JavaScript/JSMarshalerArgument+ArgumentToManagedCallback`1.xml ✅Succeeded View
xml/System.Runtime.InteropServices.JavaScript/JSMarshalerType.xml ✅Succeeded View
xml/System.Runtime.InteropServices.JavaScript/JSObject.xml ✅Succeeded View
xml/System.Runtime.InteropServices.JavaScript/JSType+Array`1.xml ✅Succeeded View
xml/System.Runtime.InteropServices.JavaScript/JSType+Function`1.xml ✅Succeeded View
xml/System.Runtime.InteropServices.JavaScript/JSType+Function`2.xml ✅Succeeded View
xml/System.Runtime.InteropServices.JavaScript/JSType+Function`3.xml ✅Succeeded View
xml/System.Runtime.InteropServices.JavaScript/JSType+Function`4.xml ✅Succeeded View
xml/System.Runtime.InteropServices.JavaScript/JSType+Promise`1.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@pavelsavara pavelsavara marked this pull request as ready for review September 27, 2022 20:10
@gewarren gewarren merged commit 270c747 into dotnet:main Sep 27, 2022
@gewarren
Copy link
Contributor

Oh sorry, I thought you were just re-requesting review from docs. Is it okay that I merged it?

@pavelsavara
Copy link
Member Author

Yes :)
I will try to use the tool to put your grammar changes back to runtime repo on that open PR.

@carlossanlop
Copy link
Contributor

Yes :) I will try to use the tool to put your grammar changes back to runtime repo on that open PR.

Unfortunately that won't work, @pavelsavara. The docs porting tool only ports new documentation (when the dotnet-api-docs xml elements have the To be added. boilerplate message).

If you want to bring your triple slash comments to dotnet-api-docs, you'll have to manually edit the files.

@gewarren
Copy link
Contributor

I think Pavel is going in the opposite direction (dotnet-api-docs -> runtime repo).

@carlossanlop
Copy link
Contributor

Ah, good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants