Repository navigation
Remove Emscripten manifest transport package - #9026
Merged
akoeplinger merged 1 commit intoSep 3, 2026
Merged
akoeplinger merged 1 commit into
akoeplinger merged 1 commit into
Conversation
Use the GenAPI task package version for runtime workload testing and remove the now-unused SDK transport package. Co-authored-by: Copilot <[email protected]> Copilot-Session: 321d7bb6-3362-45ac-8c89-6829d13167fd
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The removals and version-source substitution are consistent across SDK/runtime metadata and no remaining references to the removed transport package were found.
Pull request overview
This PR removes the Emscripten “manifest transport” package from the SDK/runtime dependency graph and switches runtime workload-testing SDK-band selection to key off the Microsoft.DotNet.GenAPI.Task package version instead.
Changes:
- Removed the (previously empty) SDK project that produced the Emscripten manifest transport package and deleted its special-casing in workload manifest packaging properties.
- Updated runtime workload-testing SDK version computation to use
MicrosoftDotNetGenAPITaskPackageVersioninstead of the removed transport-manifest version property. - Updated runtime dependency/pipeline metadata to drop the transport package and add
Microsoft.DotNet.GenAPI.Task.
File summaries
| File | Description |
|---|---|
| src/sdk/src/Workloads/Manifests/Microsoft.NET.Workload.Emscripten.Current.Transport.Manifest/Microsoft.NET.Workload.Emscripten.Current.Transport.Manifest.proj | Deletes the empty project that existed only to flow the transport manifest version. |
| src/sdk/src/Workloads/Manifests/Directory.Build.props | Removes shipping/package-id special-cases that only applied to the deleted transport-manifest project. |
| src/runtime/eng/Versions.props | Switches workload-testing SDK version selection to use the GenAPI.Task package version. |
| src/runtime/eng/Version.Details.xml | Removes the transport manifest dependency and adds Microsoft.DotNet.GenAPI.Task as a tracked dependency. |
| src/runtime/eng/Version.Details.props | Adds MicrosoftDotNetGenAPITaskPackageVersion (+ ...Version) and removes the transport-manifest version properties. |
| src/runtime/eng/pipelines/common/xplat-setup.yml | Removes the dependency-change trigger keyed to the deleted transport manifest package. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
lewing
approved these changes
Sep 3, 2026
akoeplinger
deleted the
akoeplinger/remove-emscripten-manifest-transport
branch
September 3, 2026 20:15
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Microsoft.DotNet.GenAPI.Taskto determine the SDK version for runtime workload testing. It needs to stay a non-stabilized version so the corresponding SDK can be installed via dotnet-install before it is released.Validation
Note
This pull request description was generated with GitHub Copilot.