Repository navigation
Fix build failures when building non-portable TargetRid that is different from the SDK's non-portable rid. - #8902
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This regressed in #7300. @mthalman @jkotas @akoeplinger ptal. The changes include comments that describe why what rid gets used where. |
tmds
changed the title
|
/azp run dotnet-unified-build-full |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
It would be useful to have at least one community platform coverage in this pipeline. e.g. freebsd-arm64 covers both "different OS" and "different arch" w.r.t host to avoid regressions from such changes in VMR (saves cycles). |
|
I've triggered it here https://github.com/filipnavara/dotnet-riscv/actions/runs/33807980599, need to check two things: 1) it is green 2) download artifacts and check (with BTW, preview7 slipped through some "only affects community platform" because "official platform once again got away with LKG package fallback.." and failed the preview release https://github.com/filipnavara/dotnet-riscv/actions/runs/31601669575. (not the first time this pain is shared: #7677) |
Both checked, LGTM! 👍 |
|
@tmds we needed to get the net12 PR in first, please fix the conflicts here, thanks :) |
…rent from the SDK's non-portable rid. The compilation fails when when usings a non-portable SDK (e.g. rhel.10-x64) to build a different non-portable RID (e.g. centos.10-x64). The root cause is that ILCompiler's SingleEntry.targets is not able to determine the host package and target OS for the unknown that is being built RID. This change passes that information from arcade to SingleEntry.targets.
676afe9 to
0288d9c
Compare
|
The .NET 12 PR (#8312) moved additional logic from To minimize changes for .NET 11, I've updated this PR to target the .NET 11 branch (release/11.0.1xx) with the exact changes that were already reviewed, approved and validated. I will make a separate PR for @akoeplinger can this be merged into the .NET 11 branch? Is |
The compilation fails when when usings a non-portable SDK (e.g. rhel.10-x64) to build a different non-portable RID (e.g. centos.10-x64).
The root cause is that ILCompiler's SingleEntry.targets is not able to determine the host package and target OS for the unknown that is being built RID.
This change passes that information from arcade to SingleEntry.targets.