Repository navigation
Fix component authoring - #8759
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts WiX v5 installer authoring so registry-key components used to record installed .NET versions aren’t treated as a single shared MSI component across multiple installs, reducing the chance of stale/incorrect version information remaining in the registry.
Changes:
- Removes the hard-coded
Guidon theSetupRegistry_x86WiX v5 component so component identity can vary appropriately per authored key path/version. - Keeps the authored registry key/value logic intact while aligning WiX v5 behavior with existing WiX authoring patterns in this repo.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
PranavSenthilnathan
approved these changes
Aug 28, 2026
This was referenced Aug 31, 2026
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The registry key component for writing specific version information should not be fixed. This makes it a shared component that isn't always removed, so the registry contains invalid information.
Example, when you install 10.0.9 and 10.0.10, the 10.0.10 entry remains. This can cause problems for ISVs that rely on the keys to detect specific version, potentially skipping over installs. It can also trigger scanners to report older versions that aren't actually installed.