Skip to content

[main] Source code updates from dotnet/roslyn - #7891

Merged
dkurepa merged 31 commits into
mainfrom
darc-main-3005c0f9-4087-4c0c-bd88-f964e038ea07
Aug 4, 2026
Merged

dkurepa merged 31 commits into
mainfrom
darc-main-3005c0f9-4087-4c0c-bd88-f964e038ea07

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Jul 22, 2026 •

Copy link
Copy Markdown
Contributor

Note

This is a codeflow update. It may contain both source code changes from
the source repo
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/roslyn

Diff the source with this PR branch
darc vmr diff --name-only https://github.com/dotnet/roslyn:e091fb9d8ae849cac0f577f86d5f2ffd01033b20..https://github.com/dotnet/dotnet:darc-main-3005c0f9-4087-4c0c-bd88-f964e038ea07

@dotnet-maestro

Copy link
Copy Markdown
Contributor Author

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
1 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service
dotnet-policy-service Bot requested a review from a team July 23, 2026 02:05
@dotnet-maestro

Copy link
Copy Markdown
Contributor Author

@dotnet-maestro

Copy link
Copy Markdown
Contributor Author

@dotnet-maestro

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-policy-service
dotnet-policy-service Bot requested a review from a team July 30, 2026 20:23
@dotnet-maestro

Copy link
Copy Markdown
Contributor Author

@dotnet-maestro

dotnet-maestro Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

@dkurepa

dkurepa commented Aug 3, 2026

Copy link
Copy Markdown
Member

@akhera99 we're still seeing source build failures, could you take a look? I had a stab with copilot but it tried updating some stuff in runtime which didn't look right to me

@jjonescz

jjonescz commented Aug 3, 2026

Copy link
Copy Markdown
Member

The issue seems to be that a source generator in runtime pins msbuild dependency but also references a newer one indirectly. Specifically:

src/runtime/src/tools/hotreload-delta-gen/Microsoft.DotNet.HotReload.Utils.Generator/Microsoft.DotNet.HotReload.Utils.Generator.csproj(0,0): error NU1605: Warning As Error: Detected package downgrade: Microsoft.Build.Framework from 18.7.1 to 17.11.48. Reference the package directly from the project to select a different version. 
 Microsoft.DotNet.HotReload.Utils.Generator -> Microsoft.CodeAnalysis.ExternalAccess.HotReload 5.11.0-ci -> Microsoft.Build.Framework (>= 18.7.1) 
 Microsoft.DotNet.HotReload.Utils.Generator -> Microsoft.Build.Framework (>= 17.11.48)

I think updating just the pinned reference of the generator would be a good fix. Pushed 5e1b7aa.

@dotnet-policy-service
dotnet-policy-service Bot requested a review from a team August 3, 2026 14:12
@dotnet-maestro

dotnet-maestro Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants